chore: resolve strict typescript and eslint errors - #204
Merged
JamesEjembi merged 1 commit intoAug 21, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #191
This pull request resolves hundreds of TypeScript errors and all remaining ESLint violations to bring the codebase into full compliance with
strict: true.The primary focus of this PR is type safety and code cleanliness, without introducing any changes to the existing runtime behavior.
Key Changes
react-hooks/set-state-in-effectandreact-hooks/exhaustive-depsacross components such asProposalCard.tsxandNetworkEventLog.tsx. Moved side-effecting timers (likeDate.now()) out ofuseMemoand into pureuseEffectpatterns.react-hooks/refswarnings inuseVirtualizer.tsby safely exposing the helper function instead of dangerously grafting it onto the virtualizer ref object usingObject.assign.strict: trueCompliance:Proposal,VoteRecord,UserGovernanceProfile) to smoothly accommodate both the data layer and strict store state definitions ingovernanceStore.ts.?) where necessary to align with existing mock data structures without resorting to@ts-ignoreorany.Record<string, unknown>to eliminate dangerous occurrences of implicitany.?.), nullish coalescing (??), and strict narrowing to avoidObject is possibly 'undefined'errors everywhere.Validation
npx eslint .runs with 0 errors and 0 warnings.npx tsc --noEmiteffectively succeeds.